tboudreaux/GridFire
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(engine_multiscale): resolved a major species index ordering bug

Browse Source 
All jacobian calculations were broken because the indexing used to record the AD tape was broken (see not parallel to) the indexing used by the composition object. A fix for this was to sort the network species by mass. However, more generally we should introduce a mechanism to ensure these two indexed sets always remain parallel
This commit is contained in:
Emily Boudreaux
2025-10-14 13:37:48 -04:00
parent 408f6d83a2
commit 3b8a0a1f33
10 changed files with 276 additions and 232 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/graphnet_sandbox/main.cpp
View File

@@ -23,6 +23,7 @@
#include <chrono>
#include <functional>
#include "gridfire/engine/views/engine_defined.h"
#include "gridfire/partition/composite/partition_composite.h"
static std::terminate_handler g_previousHandler = nullptr;
@@ -81,7 +82,7 @@ int main(int argc, char* argv[]){
g_previousHandler = std::set_terminate(quill_terminate_handler);
quill::Logger* logger = fourdst::logging::LogManager::getInstance().getLogger("log");
logger->set_log_level(quill::LogLevel::TraceL2);
logger->set_log_level(quill::LogLevel::TraceL3);
LOG_INFO(logger, "Starting Adaptive Engine View Example...");
using namespace gridfire;
@@ -92,7 +93,11 @@ int main(int argc, char* argv[]){
fourdst::composition::Composition composition;
composition.registerSymbol(symbols, true);
composition.setMassFraction(symbols, comp);
composition.finalize(true);
bool didFinalize = composition.finalize(true);
if (!didFinalize) {
std::cerr << "Failed to finalize initial composition." << std::endl;
return 1;
}
using partition::BasePartitionType;
const auto partitionFunction = partition::CompositePartitionFunction({
BasePartitionType::RauscherThielemann,
@@ -109,9 +114,9 @@ int main(int argc, char* argv[]){
netIn.dt0 = 1e-12;
GraphEngine ReaclibEngine(composition, partitionFunction, NetworkBuildDepth::SecondOrder);
ReaclibEngine.setUseReverseReactions(false);
ReaclibEngine.setPrecomputation(false);
// DefinedEngineView ppEngine({"p(p,e+)d", "d(p,g)he3", "he3(he3,2p)he4"}, ReaclibEngine);
MultiscalePartitioningEngineView partitioningView(ReaclibEngine);
AdaptiveEngineView adaptiveView(partitioningView);