fix(Reaction): resolved bug which prevented counting number of reactants and products properly

Browse Source

This bug was introduced when switching the internal tracking of products and reactants from a vector to a set. Initially we had done this to improve lookup performance. However, due to the uniquness of items in a set this broke counting methods. We have resolved this so that all old code will still work while maintaing the efficency gains by using an unordered map which stored species and counts. Further we have added countReactantOccurences and countProductOffurences methods to make this process more explicit and avalible to callers.

...

This commit is contained in:

Emily Boudreaux

2025-11-14 10:45:45 -05:00

parent 3335898979

commit 1500f863b6

6 changed files with 71 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

0

src/include/gridfire/engine/types/jacobian.h Normal file